test: update test implementation to work well with typescript 6#1436
Conversation
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/browser size report |
joker23
force-pushed
the
skz/sdk-2193/typescript-6-esModuleInterop-changes
branch
from
0f187c2 to
73ce3d2
Compare
|
@launchdarkly/js-client-sdk-common size report |
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 73ce3d2. Configure here.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
joker23
force-pushed
the
skz/sdk-2193/typescript-6-esModuleInterop-changes
branch
2 times, most recently
from
d2160b2 to
5010b22
Compare
kinyoklion
left a comment
kinyoklion
left a comment
There was a problem hiding this comment.
Do any of these affected packages import the package.json?
I've seen problems combining esModuleInterop with a commonjs target with loading the package.json.
Did a sweep and it looks like some packages do import |
joker23
force-pushed
the
skz/sdk-2193/typescript-6-esModuleInterop-changes
branch
from
5010b22 to
04e817d
Compare
2 participants
This PR will update the way that tests import modules. This is to make the syntax of this module compatible with typescript 6.
Specifically the issue that the current syntax runs into is detailed in https://devblogs.microsoft.com/typescript/announcing-typescript-6-0/#deprecated:---esmoduleinterop-false-and---allowsyntheticdefaultimports-false
Note
Low Risk
Test and TypeScript config-only changes with no production code paths modified.
Overview
Prepares multiple SDK packages for TypeScript 6 by turning on
esModuleInteropin theirtsconfig.jsonfiles (alongside existingallowSyntheticDefaultImports).Test fixtures that used namespace JSON imports (
import * as … from '…json') now use default imports (import … from '…json'), matching the interop model TypeScript 6 expects. Affected areas include edge SDK tests (Akamai, Cloudflare, Fastly, Vercel, Shopify Oxygen), sharedsdk-client/akamai-edgeworker-sdk/sdk-server-edgetests, and a formatting-only update topackages/sdk/fastly/jest.config.json.No runtime or library
srcchanges—only compiler settings and test import style.Reviewed by Cursor Bugbot for commit 04e817d. Bugbot is set up for automated code reviews on this repo. Configure here.